Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update babel-plugin-lodash #7131

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

pjonsson
Copy link
Contributor

@pjonsson pjonsson commented May 2, 2024

What this PR does

Switch to a forked babel-plugin-lodash
to fix the warning:

`isModuleDeclaration` has been deprecated, please migrate to `isImportOrExportDeclaration`
    at isModuleDeclaration (/app/node_modules/@babel/types/lib/validators/generated/index.js:2748:35)
    at PluginPass.Program (/app/node_modules/babel-plugin-lodash/lib/index.js:102:44)

Test me

This is tested by CI.

Checklist

  • There are unit tests to verify my changes are correct or unit tests aren't applicable (if so, write quick reason why unit tests don't exist)
  • I've updated relevant documentation in doc/.
  • I've updated CHANGES.md with what I changed.
  • I've provided instructions in the PR description on how to test this PR.

@na9da
Copy link
Collaborator

na9da commented May 3, 2024

I feel, it might be better to remove the dependency from package.json and babel config. It was added earlier to reduce bundle size bloat. If that is still the case we could revisit it later.

@pjonsson
Copy link
Contributor Author

pjonsson commented May 3, 2024

My experience is that evaluating if old functionality can be removed tends to get stuck for weeks/months, this PR removes the warning right now. And I believe the update itself is low-risk, the "new" package is just a fork of the previous package with a couple of extra commits.

Edit: and this PR does not make it harder (or easier) to remove the old functionality if you decide to do so.

Switch to a forked babel-plugin-lodash
to fix the warning:

`isModuleDeclaration` has been deprecated, please migrate to `isImportOrExportDeclaration`
    at isModuleDeclaration (/app/node_modules/@babel/types/lib/validators/generated/index.js:2748:35)
    at PluginPass.Program (/app/node_modules/babel-plugin-lodash/lib/index.js:102:44)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants