Skip to content

Commit

Permalink
changelog entry for 2804
Browse files Browse the repository at this point in the history
  • Loading branch information
minrk committed Feb 12, 2023
1 parent 0d7d599 commit 6b7d00f
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 4 deletions.
8 changes: 7 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,12 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## Unreleased

### Fixed

- Fixed duplicate output in Jupyter https://github.com/Textualize/rich/pulls/2804

## [13.3.1] - 2023-01-28

### Fixed
Expand All @@ -18,7 +24,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- Fixed failing tests due to Pygments dependency https://github.com/Textualize/rich/issues/2757
- Relaxed ipywidgets https://github.com/Textualize/rich/issues/2767

### Added
### Added

- Added `encoding` parameter in `Theme.read`

Expand Down
7 changes: 4 additions & 3 deletions rich/console.py
Original file line number Diff line number Diff line change
Expand Up @@ -944,9 +944,9 @@ def is_terminal(self) -> bool:
# Return False for Idle which claims to be a tty but can't handle ansi codes
return False

if self.is_jupyter:
# return False for Jupyter, which may have FORCE_COLOR set
return False
# if self.is_jupyter:
# # return False for Jupyter, which may have FORCE_COLOR set
# return False

# If FORCE_COLOR env var has any value at all, we assume a terminal.
force_color = self._environ.get("FORCE_COLOR")
Expand Down Expand Up @@ -1184,6 +1184,7 @@ def show_cursor(self, show: bool = True) -> bool:
Args:
show (bool, optional): Set visibility of the cursor.
"""
return False
if self.is_terminal:
self.control(Control.show_cursor(show))
return True
Expand Down

0 comments on commit 6b7d00f

Please sign in to comment.