Setting terminal window title #2200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2200 +/- ##
==========================================
- Coverage 99.46% 98.94% -0.53%
==========================================
Files 72 73 +1
Lines 7339 7606 +267
==========================================
+ Hits 7300 7526 +226
- Misses 39 80 +41
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
willmcgugan
reviewed
Apr 19, 2022
| @@ -51,3 +51,6 @@ def legacy_windows_render(buffer: Iterable[Segment], term: LegacyWindowsTerm) -> | |||
| term.erase_start_of_line() | |||
| elif mode == 2: | |||
| term.erase_line() | |||
| elif control_type == ControlType.SET_WINDOW_TITLE: | |||
There was a problem hiding this comment.
Great! Did you test this on the Windows laptop?
There was a problem hiding this comment.
I did yeah, works well there. It even automatically resets the title on both Windows Terminal and legacy Windows, so it's actually even better.
This was referenced Apr 26, 2022
1 task
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of changes
Checklist
Description
Adds support for setting the title of the terminal window.
There is no means within Rich of "resetting" the window title to its
previous value, meaning the title you set will persist even after your application
exists.
fishshell resets the window title before and after each command by default,negating this issue. Windows Terminal and command prompt will also reset the title for you.
Most other shells and terminals, however, do not do this.
Some terminals may require configuration changes before you can set the title.
Some terminals may not support setting the title at all.
Other software (including the terminal itself, the shell, custom prompts, plugins, etc.)
may also set the terminal window title. This could result in whatever value you write
using this method being overwritten.