Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forward the internal handle name wrapped in rich.progress._Reader #2254

Merged
merged 3 commits into from Jun 14, 2022
Merged

Forward the internal handle name wrapped in rich.progress._Reader #2254

merged 3 commits into from Jun 14, 2022

Conversation

althonos
Copy link
Contributor

@althonos althonos commented May 5, 2022

Type of changes

  • Bug fix
  • New feature
  • Documentation / docstrings
  • Tests
  • Other

Checklist

  • I've run the latest black with default args on new code.
  • I've updated CHANGELOG.md and CONTRIBUTORS.md where appropriate.
  • I've added tests for new code.
  • I accept that @willmcgugan may be pedantic in the code review.

Description

Hi all!

This is just a quick follow-up patch for file/progress so that the reader takes the name attribute from the internal handle. Currently, the _Reader has a name attribute (inherited from RawIOBase) but it's always None.

@willmcgugan
Copy link
Collaborator

Thanks!

@willmcgugan willmcgugan merged commit 7870603 into Textualize:master Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants