Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix interaction between Console(record=True) and Capture context manager #2343

Merged
merged 6 commits into from Jun 17, 2022

Conversation

darrenburns
Copy link
Member

@darrenburns darrenburns commented Jun 15, 2022

Type of changes

  • Bug fix
  • New feature
  • Documentation / docstrings
  • Tests
  • Other

Checklist

  • I've run the latest black with default args on new code.
  • I've updated CHANGELOG.md and CONTRIBUTORS.md where appropriate.
  • I've added tests for new code.
  • I accept that @willmcgugan may be pedantic in the code review.

Description

Fixes the issue described in #2172

@darrenburns darrenburns changed the title Capture bugfix Fix interaction between Console(record=True) and Capture context manager Jun 16, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jun 16, 2022

Codecov Report

Merging #2343 (d110847) into master (14d47c9) will decrease coverage by 0.17%.
The diff coverage is 95.67%.

@@            Coverage Diff             @@
##           master    #2343      +/-   ##
==========================================
- Coverage   98.88%   98.71%   -0.18%     
==========================================
  Files          73       73              
  Lines        7629     7704      +75     
==========================================
+ Hits         7544     7605      +61     
- Misses         85       99      +14     
Flag Coverage Δ
unittests 98.71% <95.67%> (-0.18%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
rich/_export_format.py 100.00% <ø> (ø)
rich/cells.py 100.00% <ø> (ø)
rich/live.py 97.90% <40.00%> (-2.10%) ⬇️
rich/_win32_console.py 89.94% <92.30%> (-1.54%) ⬇️
rich/console.py 98.29% <96.19%> (-0.49%) ⬇️
rich/_inspect.py 100.00% <100.00%> (ø)
rich/_wrap.py 100.00% <100.00%> (ø)
rich/box.py 100.00% <100.00%> (ø)
rich/control.py 100.00% <100.00%> (ø)
rich/progress.py 92.76% <100.00%> (+0.03%) ⬆️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 761cc8d...d110847. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants