- Sponsor
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Supporting no stdout, fix force color bug #2513
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2513 +/- ##
==========================================
+ Coverage 95.67% 98.64% +2.97%
==========================================
Files 72 73 +1
Lines 7767 7832 +65
==========================================
+ Hits 7431 7726 +295
+ Misses 336 106 -230
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might want to add a test for the correct behaviour when FORCE_COLOR is empty string
Type of changes
Checklist
Description
Fixes #2400.
Ensures RIch can run when stdout is not available (for example from pythonw).
I've tested on a Windows machine and ensured that you can use a console (and capture from it) as expected when using python.
Also fixes the issue with FORCE_COLOR.