Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose font_aspect_ratio as parameter on SVG export #2539

Merged
merged 2 commits into from Sep 23, 2022

Conversation

darrenburns
Copy link
Member

Type of changes

  • Bug fix
  • New feature
  • Documentation / docstrings
  • Tests
  • Other

Checklist

  • I've run the latest black with default args on new code.
  • I've updated CHANGELOG.md and CONTRIBUTORS.md where appropriate.
  • I've added tests for new code.
  • I accept that @willmcgugan may be pedantic in the code review.

Description

Exposes font_aspect_ratio as a parameter on export_svg and save_svg rather than hardcoding 0.61.
This is for users who would like more control over the rendering to accomodate different fonts used in their format string.

@codecov-commenter
Copy link

codecov-commenter commented Sep 23, 2022

Codecov Report

Base: 98.64% // Head: 98.46% // Decreases project coverage by -0.18% ⚠️

Coverage data is based on head (0b04aaa) compared to base (7d126c8).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2539      +/-   ##
==========================================
- Coverage   98.64%   98.46%   -0.19%     
==========================================
  Files          73       63      -10     
  Lines        7840     6779    -1061     
==========================================
- Hits         7734     6675    -1059     
+ Misses        106      104       -2     
Flag Coverage Δ
unittests 98.46% <100.00%> (-0.19%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
rich/ansi.py 100.00% <ø> (ø)
rich/filesize.py 100.00% <ø> (ø)
rich/console.py 98.01% <100.00%> (ø)
rich/markdown.py 100.00% <100.00%> (ø)
rich/pretty.py 98.98% <100.00%> (+<0.01%) ⬆️
rich/traceback.py 98.68% <100.00%> (ø)
rich/__init__.py
rich/tree.py
rich/columns.py
rich/screen.py
... and 6 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[REQUEST] Add support for more characters for SVG formatting
3 participants