Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes #2991 by adjusting the y scroll after max_lines exceeded #3005

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

mardanst
Copy link
Contributor

Please review the following checklist.

  • Docstrings on all new or modified functions / classes
  • Updated documentation
  • Updated CHANGELOG.md (where appropriate)

@rodrigogiraoserrao
Copy link
Contributor

Hey @mardanst, thanks for the PR.

Before we take a look at it, could you make sure the tests pass locally?
You can go through the steps outlined in #2923, from the section "Guidelines" onwards.
Thanks!

@mardanst
Copy link
Contributor Author

mardanst commented Jul 25, 2023

Thanks @rodrigogiraoserrao, that link was very helpful. I was able to fix the failing test and add a new snapshot test for #2991 .

Tests are passing locally, but failing in github on (windows-latest,3.11) on an unrelated test.

@mardanst
Copy link
Contributor Author

Resubmitted it and it passed the second time through

@rodrigogiraoserrao
Copy link
Contributor

Thanks for following up on it. We'll take a look and get back to you.

As you realised, some of our tests are a bit flakey. When one of those fails, no need to create a "fake" commit to trigger them again. We'll rerun them for you :)

@rodrigogiraoserrao
Copy link
Contributor

Hey @mardanst, sadly we let this slip and now there have been some modifications to TextLog (which is now RichLog) and we've added a new Log widget. (See #3046 for some more context.)

Are you keen on bringing your PR up to date (possibly closing this one and making a new one against the head of main), or do you want to dissociate yourself from this PR and leave it up to us to fix the issue that this PR tackles?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants