Add information about ToastRack styling to the toast widget documentation #4492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Dave Pearson <davep.org@gmail.com>
Co-authored-by: Dave Pearson <davep.org@gmail.com>
merriam
reviewed
May 27, 2024
There was a problem hiding this comment.
Sorry, I'm a bit confused. There are three classes from _toast.py, each with its own DEFAULT_CSS: the Toast (short lived notification), the ToastHolder (the little box holding one Toast), and the ToastRack (the bigger box, holding ToastHolders). They don't inherit, so changing a ToastRack width to 2fr would still leave the ToastHolder widths at 1fr and Toast width at 60.
Your change makes the ToastRack align to the right bottom, and the other example makes an imperceptible change to padding. Perhaps a better example could move toasts to long skinny toasts from the the top left of the screen and in different colors?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add information about ToastRack styling to the toast widget documentation
As requested in: #4473
Please review the following checklist.