Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: enable OverrideBothEqualsAndHashcode like checks #5159

Merged
merged 1 commit into from May 20, 2024

Conversation

vil02
Copy link
Member

@vil02 vil02 commented May 12, 2024

Thanks to #5157 we can enable these checks in SpotBugs and PMD.

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized it.
  • All filenames are in PascalCase.
  • All functions and variable names follow Java naming conventions.
  • All new algorithms have a URL in their comments that points to Wikipedia or other similar explanations.
  • All new code is formatted with clang-format -i --style=file path/to/your/file.java

@codecov-commenter
Copy link

codecov-commenter commented May 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 38.56%. Comparing base (8466219) to head (ec1c627).

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #5159      +/-   ##
============================================
- Coverage     38.57%   38.56%   -0.02%     
+ Complexity     2379     2378       -1     
============================================
  Files           516      516              
  Lines         15313    15313              
  Branches       2957     2957              
============================================
- Hits           5907     5905       -2     
- Misses         9121     9122       +1     
- Partials        285      286       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vil02 vil02 marked this pull request as ready for review May 12, 2024 10:59
@vil02 vil02 force-pushed the include_HE_EQUALS_USE_HASHCODE branch 2 times, most recently from 2981fc4 to 44dd656 Compare May 17, 2024 09:58
@vil02 vil02 enabled auto-merge (squash) May 18, 2024 10:39
@vil02 vil02 force-pushed the include_HE_EQUALS_USE_HASHCODE branch 2 times, most recently from 184bb74 to 9a24f26 Compare May 19, 2024 19:33
@vil02 vil02 force-pushed the include_HE_EQUALS_USE_HASHCODE branch from 9a24f26 to ec1c627 Compare May 20, 2024 16:04
@vil02 vil02 merged commit 324969f into TheAlgorithms:master May 20, 2024
3 checks passed
@vil02 vil02 deleted the include_HE_EQUALS_USE_HASHCODE branch May 20, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants