Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added doctests, exceptions, type hints, fixed bug, remove trailing whitespace for infix_to_prefix_conversion #10063

Closed
wants to merge 0 commits into from
Closed

Added doctests, exceptions, type hints, fixed bug, remove trailing whitespace for infix_to_prefix_conversion #10063

wants to merge 0 commits into from

Conversation

hollowcrust
Copy link
Contributor

@hollowcrust hollowcrust commented Oct 8, 2023 •
edited

Describe your change:

Fixes #9943

File affected: data_structures/stacks/infix_to_prefix_conversion.py

  • Added doctests
  • Added exceptions for expressions with invalid bracket positions
  • Added type hints for functions
  • Edited code to ensure no trailing whitespaces in code and doctests
  • Fixed a bug on line 53 (original file) by adding a condition and stack[-1] != "("
  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

@algorithms-keeper algorithms-keeper bot added enhancement This PR modified some existing files awaiting reviews This PR is ready to be reviewed tests are failing Do not merge until tests pass and removed tests are failing Do not merge until tests pass labels Oct 8, 2023
@algorithms-keeper algorithms-keeper bot mentioned this pull request Oct 8, 2023
Closed
14 tasks
@hollowcrust hollowcrust changed the title Added doctests, exceptions, type hints, fixed bug for infix_to_prefix_conversion Added doctests, exceptions, type hints, fixed bug, remove trailing whitespace for infix_to_prefix_conversion Oct 8, 2023
cclauss
cclauss reviewed Oct 8, 2023
View reviewed changes
data_structures/stacks/infix_to_prefix_conversion.py Outdated
@@ -15,7 +15,7 @@
"""


def infix_2_postfix(infix):
def infix_2_postfix(infix: str) -> str:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BEFORE we modify this function we need it to have doctests. You can do that in a separate pull request and then we can circle back to this pull request AFTER the doctests have been merged.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm reaching my PR limit so maybe I can commit changes directly here or can you help me review #10073 or #10012 first?

Copy link
Member

@cclauss cclauss Oct 8, 2023 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I merged one of them that adds tests. The other one deletes the work of others but perhaps it is the right thing to do.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok thanks i'll work on this

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cclauss I added tests in #10095, you can help me look through.

@hollowcrust hollowcrust mentioned this pull request Oct 8, 2023
Closed
14 tasks
@algorithms-keeper algorithms-keeper bot added tests are failing Do not merge until tests pass and removed tests are failing Do not merge until tests pass labels Oct 8, 2023
@hollowcrust hollowcrust mentioned this pull request Oct 8, 2023
Merged
14 tasks
@cclauss
Copy link
Member

cclauss commented Oct 10, 2023 •
edited

Please rebase to fix to resolve the git conflict.

If you are unsure how to do that, please close this pull request and then create a new one.

@cclauss cclauss requested a review from sanskark October 10, 2023 17:04
@hollowcrust hollowcrust deleted the patch-1 branch October 11, 2023 00:11
@hollowcrust hollowcrust restored the patch-1 branch October 11, 2023 00:23
@hollowcrust hollowcrust mentioned this pull request Oct 11, 2023
Merged
14 tasks
@hollowcrust
Copy link
Contributor Author

@cclauss I created a new PR #10259, you can help me check it please.

@hollowcrust hollowcrust deleted the patch-1 branch October 11, 2023 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cclauss cclauss cclauss left review comments

@sanskark sanskark Awaiting requested review from sanskark

Assignees
No one assigned
Labels
awaiting reviews This PR is ready to be reviewed enhancement This PR modified some existing files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve our test coverage
3 participants
@hollowcrust @cclauss @sanskark