feat: new lesson chip #4531
Open
feat: new lesson chip #4531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do you need anyone else to do anything with this mate? |
01zulfi
force-pushed
the
feat/new-lesson-chip
branch
from
5cd0cd3
to
0818cb4
Compare
01zulfi
force-pushed
the
feat/new-lesson-chip
branch
from
0818cb4
to
3d6d144
Compare
|
@CouchofTomato not sure, I can take this to completion. Will need help if there any other changes required |
There was a problem hiding this comment.
This is looking ace @01zulfi, nice work! Just a few small suggestions from me.
One problem we'll have, is every lesson will be marked as "new" on fresh installations of the app locally and on review apps. But I'm not sure if that really is a problem, and I can't think of a reasonable way around it. We might just have to document it if contributors are confused by it.
01zulfi
force-pushed
the
feat/new-lesson-chip
branch
from
3d6d144
to
fd1a7c9
Compare
| @@ -20,6 +20,10 @@ class Lesson < ApplicationRecord | |||
|
|
|||
| attribute :completed, :boolean, default: false | |||
|
|
|||
| def recently_added? | |||
| created_at > 2.weeks.ago.beginning_of_day | |||
There was a problem hiding this comment.
beginning_of_day nice touch! 🤌
01zulfi
force-pushed
the
feat/new-lesson-chip
branch
from
fd1a7c9
to
3ae3b48
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because
testing if adding a lesson chip is viable
This PR
adds "new" lesson chip
Issue
Closes #XXXXX
Additional Information
Pull Request Requirements
keyword: brief description of changeformat, using one of the following keywords:Feature- adds new or amends existing user-facing behaviorChore- changes that have no user-facing value, refactors, dependency bumps, etcFix- bug fixesBecausesection summarizes the reason for this PRThis PRsection has a bullet point list describing the changes in this PRIssuesection