Improve hover support #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WillLillis
force-pushed
the
hover_support
branch
from
ef05a17
to
3432066
Compare
|
i think this makes sense, i'll go with it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! I was trying the project out of the test file and initially thought hover support wasn't implemented because I couldn't get a hover window on
hx-targetin the file's initial state. I then changed the hover support implementation before realizing that I just needed to provide a value forhx-targetand close off the div.This PR allows for hover functionality even when a div isn't closed off (and thus even when tree-sitter's CST of the buffer contains some errors near the cursor), as in the initial state of the test file. If this behavior isn't desired, I completely understand :). I'm still familiarizing myself with the codebase, so if I unwittingly made any goofy decisions I'm happy to fix/ refactor things as needed. Some demos:
Before:
After: