Skip to content
This repository has been archived by the owner on Aug 18, 2021. It is now read-only.

Feature/csharp #40

Closed

Conversation

LukasHabring
Copy link

Added csharp as target language.
Unfortunately I had to remove gogoproto in order to do that.
Results should be binary compatible though.

@CLAassistant
Copy link

CLAassistant commented Jun 24, 2020

CLA assistant check
All committers have signed the CLA.

@jpmeijers
Copy link
Contributor

jpmeijers commented Jun 25, 2020

I believe you are experiencing the same issue as java, documented in #30. Can you try that workaround?

After speaking to the gogoproto maintainer it sounds like an issue of proto3 dropping features that proto2 had, that gogoproto depends on. And that the java and dotnet proto compilers don't support proto2 properly.

https://stackoverflow.com/questions/41833044/c-sharp-code-generation-with-google-protobuf-proto2-files

protocolbuffers/protobuf#6067

@LukasHabring
Copy link
Author

@jpmeijers Thank you for your reply. It should be fixed now.

@htdvisser
Copy link
Contributor

I'm going to close this stale pull request. We don't intend to make any changes to this repository since V2 is permanently shutting down in December.

@htdvisser htdvisser closed this Aug 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants