-
Notifications
You must be signed in to change notification settings - Fork 299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Pub/Sub MQTT driver context propagation #3343
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adriansmares
added
bug
Something isn't working
prio/high
c/application server
This is related to the Application Server
labels
Oct 9, 2020
adriansmares
requested review from
htdvisser,
KrishnaIyer and
rvolosatovs
as code owners
October 9, 2020 11:49
github-actions
bot
added
dependencies
Pull requests that update a dependency file
documentation
This involves writing user documentation
labels
Oct 9, 2020
adriansmares
force-pushed
the
fix/3338-paho-wait-timeout
branch
from
October 9, 2020 12:10
fa75a9b
to
2601cad
Compare
htdvisser
reviewed
Oct 12, 2020
Comment on lines
-19
to
-20
// Remove this once https://github.com/eclipse/paho.mqtt.golang/pull/451 is merged. | ||
replace github.com/eclipse/paho.mqtt.golang => github.com/johanstokking/paho.mqtt.golang v1.2.1-0.20200917115254-cf2daad9593e |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably smart to keep a replacement to the latest master, otherwise a dependency upgrade may accidentally revert it to v1.2.0.
adriansmares
force-pushed
the
fix/3338-paho-wait-timeout
branch
from
October 16, 2020 11:25
677572a
to
51da087
Compare
adriansmares
force-pushed
the
fix/3338-paho-wait-timeout
branch
from
October 16, 2020 11:30
51da087
to
eebcb4f
Compare
htdvisser
approved these changes
Oct 19, 2020
johanstokking
approved these changes
Oct 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Something isn't working
c/application server
This is related to the Application Server
dependencies
Pull requests that update a dependency file
documentation
This involves writing user documentation
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #3338
Changes
ba85050a1f23
NotFound
errors) - we've actually observed this in production when the link to Redis stops, and the task stopsnil
error. This makes code that usesctx.Done
andctx.Err
to miss the cancellationTesting
Unit testing covers this.
Regressions
As this touches the MQTT driver timeouts, and a bit of the linking/pub/sub startup logic, regressions can occur there. However, the changes actually make us more lenient in task restarts (since we now actually propagate the errors better).
Checklist
README.md
for the chosen target branch.CHANGELOG.md
.CONTRIBUTING.md
, there are no fixup commits left.