Fix incorrect handling of 64-bit CSR in 32-bit mode: no truncate when updating RegisterFile #218
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RARS loops forever when running the following code
But after uncommenting
# mv t0 t0
the code runs as expected (sleeps for 3 seconds).This happened, I believe, when calling
RegisterBlock.updateRegister
e. g. here without truncating 64-bit values of a CSR. As the result,t0
keeps value larger than 32-bit MAX_VALUE until any operation is performed on it.Simplest way is to fix this near the root of the problem — when updating a register block (otherwise we have to check out all the 32/64 API mismatches though the code).