Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance management of urlscan.io results #100

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

madCdan
Copy link

@madCdan madCdan commented Jul 8, 2022

Enhance management of urlscan.io results :

  • urlscan.io: Instead of having a fixed 45 seconds delay between submission and result retrieval, implement a polling logic with an initial 20 seconds delay and retry every 5 seconds until a total a 120 seconds is reached
  • urlscan.io: Only try to print verdicts if hasVerdicts==True

Description

This PR enhances the management of urlscan.io results
Before that, a fixed 45 seconds delay was used between submission and retrieval of results which could lead in being unable to retrieve results if the 45 seconds delay is not enough (had the problem yesterday).

Type of Change

Please delete any options that do not apply here:

  • Bug Fix

…ission and result retrieval, implement a polling logic with an initial 20 seconds delay and retry every 5 seconds until a total a 120 seconds is reached

- urlscan.io: Only try to print verdicts if hasVerdicts==True
@Benj1Dev
Copy link

Benj1Dev commented Jul 8, 2022

I was able to replicate the issue and to apply the recommended fix, it works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants