fix: allow tags in npm:x-deps (#194)

Thinkmill · Jan 14, 2024 · 56a64c5 · 56a64c5
1 parent 7ef91be
commit 56a64c5
Show file tree

Hide file tree

Showing 3 changed files with 23 additions and 0 deletions.
diff --git a/.changeset/chatty-pillows-enjoy.md b/.changeset/chatty-pillows-enjoy.md
@@ -0,0 +1,5 @@
+---
+"@manypkg/cli": patch
+---
+
+fix: allow tags in `npm:x`-deps
diff --git a/packages/cli/src/checks/INTERNAL_MISMATCH.ts b/packages/cli/src/checks/INTERNAL_MISMATCH.ts
@@ -22,8 +22,10 @@ export default makeCheck<ErrorType>({
         for (let depName in deps) {
           let range = deps[depName];
           let dependencyWorkspace = allWorkspaces.get(depName);
+
           if (
             dependencyWorkspace !== undefined &&
+            !range.startsWith("npm:") &&
             !semver.satisfies(dependencyWorkspace.packageJson.version, range)
           ) {
             errors.push({

diff --git a/packages/cli/src/checks/__tests__/INTERNAL_MISMATCH.ts b/packages/cli/src/checks/__tests__/INTERNAL_MISMATCH.ts
@@ -85,4 +85,20 @@ describe("internal mismatch", () => {
       ]
     `);
   });
+
+  // regression test for https://github.com/Thinkmill/manypkg/issues/193
+  it.each(["npm:pkg-1@sometag", "npm:@someorg/pkg-1@sometag"])(
+    "should not error when using tag %s",
+    (range) => {
+      let ws = getWS();
+      let dependsOnOne = getFakeWS("depends-on-one");
+      dependsOnOne.packageJson.dependencies = {
+        "pkg-1": range,
+      };
+      ws.set("depends-on-one", dependsOnOne);
+      let errors = makeCheck.validate(dependsOnOne, ws, rootWorkspace, {});
+      expect(errors.length).toEqual(0);
+    }
+  );
+
 });