Fix Upgrade to Properly Update Scoped Packages (#206)

Thinkmill · Apr 14, 2024 · c2c4a3b · c2c4a3b
1 parent 5883214
commit c2c4a3b
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/.changeset/weak-icons-invent.md b/.changeset/weak-icons-invent.md
@@ -0,0 +1,5 @@
+---
+"@manypkg/cli": patch
+---
+
+Fix `manypkg upgrade @scope` upgrading packages like `@scope-something/a`
diff --git a/packages/cli/src/upgrade.ts b/packages/cli/src/upgrade.ts
@@ -24,7 +24,7 @@ export async function upgradeDependency([name, tag = "latest"]: string[]) {
 
       let packageNames = Object.keys(deps);
       packageNames.forEach((pkgName) => {
-        if ((isScope && pkgName.startsWith(name)) || pkgName === name) {
+        if ((isScope && pkgName.startsWith(`${name}/`)) || pkgName === name) {
           requiresUpdate = true;
           packagesToUpdate.add(pkgName);
         }
@@ -42,7 +42,7 @@ export async function upgradeDependency([name, tag = "latest"]: string[]) {
 
       let packageNames = Object.keys(deps);
       packageNames.forEach((pkgName) => {
-        if ((isScope && pkgName.startsWith(name)) || pkgName === name) {
+        if ((isScope && pkgName.startsWith(`${name}/`)) || pkgName === name) {
           rootRequiresUpdate = true;
           packagesToUpdate.add(pkgName);
         }