Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore support for Bolt monorepos #174

Merged
merged 3 commits into from
Jun 9, 2023
Merged

Conversation

steve-taylor
Copy link
Contributor

@steve-taylor steve-taylor commented Apr 10, 2023

This addresses #172 by reverting #165, with some minor modifications that I've annotated in comments.

@changeset-bot
Copy link

changeset-bot bot commented Apr 10, 2023

🦋 Changeset detected

Latest commit: 5e60c8f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@manypkg/get-packages Minor
@manypkg/find-root Minor
@manypkg/tools Minor
@manypkg/cli Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

packageJson: PackageJSON;
dir: string;
relativeDir: string;
}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added Tool and Package here as Packages (below) refers to them. Not sure if that's needed/wanted. Happy to remove.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perhaps we should refer to them as import('@manypkg/tools').Tool etc? This way we wouldn't have to worry about syncing those definitions in READMEs and it would be clear from where they are coming from here

@steve-taylor steve-taylor marked this pull request as ready for review April 10, 2023 10:21
Co-authored-by: Mateusz Burzyński <mateuszburzynski@gmail.com>
@@ -21,6 +22,7 @@ import {
*/
const DEFAULT_TOOLS: Tool[] = [
YarnTool,
BoltTool,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would it work if we'd put BoltTool at the end?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, it still works. I moved it down. It's still above RootTool as it seems likeRootTool should always be last.

Anything else or are we good to merge?

@Andarist Andarist merged commit de0fff3 into Thinkmill:main Jun 9, 2023
2 checks passed
@github-actions github-actions bot mentioned this pull request Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants