Support of Rollup 2.x.x #3
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Seems, there's an official way to check which signature of `writeBundle` used in current Rollup's version. Check this comment: ``` So you can detect the signature of the hook by checking if the second parameter is used; in that case, it is the bundle, otherwise the first is the bundle. ``` rollup/rollup#3361 (comment)
|
@ThomZz Will be very appreciated for fast merge and publish! |
|
Yep, just need to take the time to ensure it is fully compatible.. I hardly see how it can be, as I use the two arguments distinctively. |
|
I'm not very familiar with rollup plugins, but it’s the way described by maintainer in official PR. So, most likely it should work. |
|
Compatibility issues between rollup v1 and v2 are fixed with : 52e8ff2 Changes has been tested with rollup 1.27.1 and rollup 2.32.1. New version has been push to NPM (1.1.0) (damn, no CI !!). Regards, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems, there's an official way to check which signature of
writeBundleused in current Rollup's version. Check this comment:rollup/rollup#3361 (comment)