Add generic jsonendpoint adapter #333
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkotik
changed the title
dkotik
commented
Feb 4, 2023
| @@ -1,6 +1,6 @@ | |||
| module github.com/ThreeDotsLabs/watermill | |||
|
|
|||
| go 1.17 | |||
| go 1.18 | |||
There was a problem hiding this comment.
Required for generics support
Previously, the endpoint adapter would return `nil` on success, which
is invalid JavaScript Object Notation format. It should be "{}".
Added UUID to make the adapter useful in more use cases.
For example, the returned value can serve as a shopping cart order ID.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Package jsonendpoint provides a generic adapter that converts a validated JSON request into a [message.Message] published to a certain topic. Use together with an HTTP router to build gateways to any [message.Publisher].
Had to bump Golang version to
1.18in thego.modfile to support generics.This is my first contribution.