Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added request-reply support for commands #366

Draft
wants to merge 22 commits into
base: event-handler-groups-cleanup
Choose a base branch
from

Conversation

roblaszczak
Copy link
Member

No description provided.

@roblaszczak roblaszczak changed the base branch from master to event-handler-groups-cleanup June 8, 2023 10:57
# Conflicts:
#	components/cqrs/command_bus.go
#	components/cqrs/command_config.go
#	components/cqrs/command_config_test.go
#	components/cqrs/command_processor.go
#	components/cqrs/command_processor_test.go
#	components/cqrs/cqrs_test.go
#	components/cqrs/event_bus.go
#	components/cqrs/event_config.go
#	components/cqrs/event_config_test.go
#	components/cqrs/event_handler.go
#	components/cqrs/event_processor.go
@AlexCuse
Copy link
Contributor

AlexCuse commented Jun 8, 2023

This is awesome I've stitched together an ad-hoc equivalent to this at least a few times be nice to have something available in package.

@AlexCuse
Copy link
Contributor

Been thinking about this a lot you may want to drop the CQRS namespace since request / reply is generally useful in a lot of situations. I don't have a great name in mind though. We built it into the message bus client for edgexfoundry mainly for the performance benefits that come with sending command/control messages to local device services without using HTTP.

The messagebus implementation is not really too much different than a composite of a WM publisher and subscriber. Its super easy to adapt between the two. In case you want to look could start here https://github.com/edgexfoundry/go-mod-messaging/blob/main/internal/pkg/request.go

@qiulin
Copy link

qiulin commented Jul 17, 2023

Is there any process?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants