SSE htmx example #435
Draft
SSE htmx example #435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roblaszczak
reviewed
Apr 21, 2024
| return nil | ||
| }) | ||
|
|
||
| router, err := message.NewRouter(message.RouterConfig{}, logger) |
There was a problem hiding this comment.
it may be good to rename reouter to watermillRouter or something to not mess it with http
roblaszczak
reviewed
Apr 21, 2024
| return nil, err | ||
| } | ||
|
|
||
| err = storage.UpdatePost(context.Background(), event.PostID, func(post *Post) { |
There was a problem hiding this comment.
don't you want to use ctx from msg?
roblaszczak
reviewed
Apr 21, 2024
| publisher, | ||
| func(msg *message.Message) ([]*message.Message, error) { | ||
| var event PostReactionAdded | ||
| err := json.Unmarshal(msg.Payload, &event) |
There was a problem hiding this comment.
I wonder if it wouldn't be worth to use cqrs here?
roblaszczak
reviewed
Apr 21, 2024
| return buffer.String(), nil | ||
| } | ||
|
|
||
| type Storage struct { |
There was a problem hiding this comment.
what about naming it repository?
roblaszczak
reviewed
Apr 21, 2024
| subscriber, err := googlecloud.NewSubscriber(googlecloud.SubscriberConfig{ | ||
| ProjectID: cfg.PubSubProjectID, | ||
| GenerateSubscriptionName: func(topic string) string { | ||
| return fmt.Sprintf("%v_%v", topic, watermill.NewShortUUID()) |
There was a problem hiding this comment.
maybe some comment will be useful here, why we are using shortuuid etc.?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.