Add support for other verbs for aggregation. #1389
Conversation
Cherry picked from ThreeMammals#1389
|
Hi Carl! Could you Sync fork please? So, your develop branch is outdated! |
raman-m
added
proposal
| // Only supports GET..are you crazy!! POST, PUT WOULD BE CRAZY!! :) | ||
| public List<string> UpstreamHttpMethod => new() { "Get" }; | ||
|
|
||
| public List<string> UpstreamHttpMethod { get; private set; } = new(); |
There was a problem hiding this comment.
private set means you can assign the value by constructor only.
In this case default constructor creates the list.
No much sense to make setter private:
- another properties have public setter
- we can unit test this property
| private Route SetUpAggregateRoute(IEnumerable<Route> routes, FileAggregateRoute aggregateRoute, FileGlobalConfiguration globalConfiguration) | ||
| { | ||
| if (!aggregateRoute.UpstreamHttpMethod.Any()) | ||
| { | ||
| // Default method to Get for standard use case | ||
| aggregateRoute.UpstreamHttpMethod.Add(HttpMethod.Get.ToString()); | ||
| } | ||
|
|
There was a problem hiding this comment.
We have to unit test this code.
There was a problem hiding this comment.
HttpMethod.Get.ToString() should be a static field of class
raman-m
force-pushed
the
user/carl-aggregate-methods
branch
from
5b5bfb0
to
8596743
Compare
|
The feature branch has been rebased onto ThreeMammals:develop! I see that develop branch in your fork is too old! |
raman-m
requested review from
binarymash,
jps,
geffzhang,
RaynaldM,
philproctor,
anktsrkr,
sharpn,
abooraja,
wast,
raman-m,
yangzhongke and
thiagoloureiro
| private Route SetUpAggregateRoute(IEnumerable<Route> routes, FileAggregateRoute aggregateRoute, FileGlobalConfiguration globalConfiguration) | ||
| { | ||
| if (!aggregateRoute.UpstreamHttpMethod.Any()) | ||
| { | ||
| // Default method to Get for standard use case | ||
| aggregateRoute.UpstreamHttpMethod.Add(HttpMethod.Get.ToString()); | ||
| } | ||
|
|
There was a problem hiding this comment.
HttpMethod.Get.ToString() should be a static field of class
This changes the FileAggregateRoute to allow other verbs.
It is for consumers not following traditional REST. Several APIs do not follow the REST guidelines and may use POST for getting data. In cases like these being able to specify a verb is helpful.