Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add info about MMLib.SwaggerForOcelot to notsupported.rst #1429

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

Burgyn
Copy link

@Burgyn Burgyn commented Feb 5, 2021

Hi,

first of all, thank you for this great project and for actively taking care of it.


Many people are still looking for a way to aggregate their microservice documentation directly on the API Gateway. This is what my MMLib.SwaggerForOcelot project provides. I know it doesn't cover all scenarios like people use Ocelot, but a lot of it.
Many people use this package.

I prepared this PR so that people who are looking for a way to do it can find a solution faster. I will be happy if it gets into this documentation. However, I will understand if you reject this PR.

Thank you again.

@Burgyn
Copy link
Author

Burgyn commented Feb 12, 2021

Hi,

some acceptance test failed. But I'm not sure how this can be caused by a change in the documentation. I tried to find a connection, but in vain.

@Burgyn
Copy link
Author

Burgyn commented Dec 29, 2022

Hi @TomPallister ,

Please 🙏 can you check this PR?
Thanks.

@raman-m
Copy link
Member

raman-m commented Jul 11, 2023

@Burgyn commented on Feb 12, 2021

Don't worry! The latest build is green! 😺

@raman-m
Copy link
Member

raman-m commented Jul 11, 2023

Burgyn commented on Dec 29, 2022

I will check the PR!

Tom has no intention to develop this product because he was greatly inspired by Microsoft's YARP gateway in 2020. 🤣
Also, Tom has moved to another tech stack of Node.js and TypeScript. So, he has no much interest in leading his .NET project anymore.
This is the truth! And reality...

@raman-m
Copy link
Member

raman-m commented Jul 11, 2023

Burgyn commented on Feb 5, 2021:

Many people are still looking for a way to aggregate their microservice documentation directly on the API Gateway. This is what my MMLib.SwaggerForOcelot project provides. I know it doesn't cover all scenarios like people use Ocelot, but a lot of it. Many people use this package.

Wow! I am impressed! So, cool package you've designed and built! 🥇


Burgyn/MMLib.SwaggerForOcelot | MMLib.SwaggerForOcelot.csproj

It uses Ocelot v18 which is .NET 6 release.
Do you have a plan to upgrade your project to .NET 7 and reuse Ocelot v19?
We have made .NET 7 release on April 23.

@raman-m
Copy link
Member

raman-m commented Jul 11, 2023

I prepared this PR so that people who are looking for a way to do it can find a solution faster. I will be happy if it gets into this documentation. However, I will understand if you reject this PR.

We will not reject your request!
You just want to update the Not Supported section in docs.

Now I need to think about the right way we could move on...
Well...

  • 1st, I don't like current Not Supported docs section. It is not structured well. It should be reviewed at least.
  • 2nd, We have no sample web app for current instructions to enable Swagger being written by Tom. We could add a sample with default Swagger settings
  • 3rd, your PR could have a new sample web app with the reference to your MMLib.SwaggerForOcelot package.

I believe, we need to convert this simple docs updating PR to real feature request, and work more on a sample. And sure we will update docs.

So, What about converting your PR to a feature request with more advanced description?

Any ideas are welcome!

@raman-m raman-m added help wanted Not actively being worked on. If you plan to contribute, please drop a note. question Initially seen a question could become a new feature or bug or closed ;) medium effort Likely a few days of development effort proposal Proposal for a new functionality in Ocelot needs feedback Issue is waiting on feedback before acceptance documentation Needs a documentation update waiting Waiting for answer to question or feedback from issue raiser labels Jul 11, 2023
@Burgyn
Copy link
Author

Burgyn commented Jul 13, 2023

Hi @raman-m,

thanks for your replays.

I will check the PR!
Tom has no intention to develop this product because he was greatly inspired by Microsoft's [YARP]> (https://github.com/microsoft/reverse-proxy) gateway in 2020. 🤣
Also, Tom has moved to another tech stack of Node.js and TypeScript. So, he has no much interest in leading his .NET project anymore.
This is the truth! And reality...

Yes I know about that. I understand his decision and I fully respect it.

Wow! I am impressed! So, cool package you've designed and built! 🥇

Thanks, it came out of necessity and people started using it 🙂.

It uses Ocelot v18 which is .NET 6 release.
Do you have a plan to upgrade your project to .NET 7 and reuse Ocelot v19?
We have made .NET 7 release on April 23.

Yes, I'm updating my project. I don't actively follow it, I only do it when someone notifies me. I will do it in the next few days.

So, What about converting your PR to a feature request with more advanced description?

It makes sense. I'll take a look at it and try to make a meaningful demo. It won't be right away though, I expect a couple of weeks before I get around to it.

@Burgyn
Copy link
Author

Burgyn commented Jul 13, 2023

Hi @raman-m

It uses Ocelot v18 which is .NET 6 release.
Do you have a plan to upgrade your project to .NET 7 and reuse Ocelot v19?
We have made .NET 7 release on April 23.

New version of my package with Ocelot 19 and .NET 7 was released.

@raman-m
Copy link
Member

raman-m commented Jul 14, 2023

New version of my package with Ocelot 19 and .NET 7 was released.

Wow! This is just great news! Congrats! 🥳


Also, could you sync your fork please? Your forked repo is outdated (develop branch).
Or you can merge this PR 1 with rebase option.

@Burgyn
Copy link
Author

Burgyn commented Jul 16, 2023

Hi,

Also, could you sync your fork please? Your forked repo is outdated (develop branch).
Or you can merge this PR 1 with rebase option.

My forked repository is now up to date.

@raman-m
Copy link
Member

raman-m commented Jul 17, 2023

My forked repository is now up to date.

Not yet! 😜
Your master branch is still behind ThreeMammals's one. 😉
I know master is not default branch now, but you could sync everything by Sync fork button.

@Burgyn
Copy link
Author

Burgyn commented Jul 17, 2023

Done 🙂

@raman-m
Copy link
Member

raman-m commented Aug 23, 2023

@Burgyn commented on Jul 13

It makes sense. I'll take a look at it and try to make a meaningful demo. It won't be right away though, I expect a couple of weeks before I get around to it.

What about demo and sample app?
Do you have a time to contribute?
It seems it will be another PR for another feature branch...

@raman-m
Copy link
Member

raman-m commented Oct 30, 2023

@raman-m commented on Aug 23

@Burgyn Hi Miňo!
I've asked you about a demo 2 months ago... No feedbacks from you!
Are you still with Ocelot?
Can we plan to develop this feature or close this PR?
I believe we could add a sample app to demonstrate the power of your library.

@Burgyn
Copy link
Author

Burgyn commented Nov 1, 2023

Hi @raman-m,
Sorry for the delayed response. I've been quite busy lately.

I plan to create a demo and probably submit it as a new PR sometime in December.
Thanks for your patience.

@raman-m
Copy link
Member

raman-m commented Nov 25, 2023

We are waiting you returning to us back in December...

@raman-m
Copy link
Member

raman-m commented Feb 1, 2024

Should care about #989 too via reopening... ☝️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Needs a documentation update help wanted Not actively being worked on. If you plan to contribute, please drop a note. high High priority medium effort Likely a few days of development effort needs feedback Issue is waiting on feedback before acceptance proposal Proposal for a new functionality in Ocelot question Initially seen a question could become a new feature or bug or closed ;) waiting Waiting for answer to question or feedback from issue raiser
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants