feat: upgrade to postcss@8 #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: Require postcss@8
stefanprobst
commented
Apr 7, 2021
| "cssnano-preset-simple": "^2.0.0" | ||
| }, | ||
| "peerDependencies": { | ||
| "postcss": "^8.2.2" |
There was a problem hiding this comment.
v8.2.2 is needed (i think): see postcss/postcss#1485
There was a problem hiding this comment.
Timer/cssnano-preset-simple@42a4d11 is using ^8.2.8 @stefanprobst
|
This would prevent Next.js apps from complaining about CVE-2021-23368. Snyk report: https://snyk.io/vuln/SNYK-JS-POSTCSS-1090595 |
mazipan
reviewed
Apr 13, 2021
| } | ||
|
|
||
| module.exports = postcss.plugin('cssnano-simple', (opts = {}) => { | ||
| module.exports = (opts = {}) => { |
There was a problem hiding this comment.
The changes were too much.
We need to check all the functionality in my opinion.
|
This looks great to me, thanks! |
Timer
approved these changes
Apr 13, 2021
|
🎉 This PR is included in version 2.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #10
closes vercel/next.js#23620
this updates postcss to v8