Chore: Cosmetic changes to how we resolve session properties for a model #2603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
georgesittas
approved these changes
May 13, 2024
tobymao
reviewed
May 13, 2024
| ) -> t.Optional[exp.Expression]: | ||
| if isinstance(provided, dict): | ||
| session_properties = {k: exp.Literal.string(k).eq(v) for k, v in provided.items()} | ||
| elif provided: | ||
| session_properties = {expr.this.name: expr for expr in provided} |
There was a problem hiding this comment.
what is expr? what are you expecting it to be such that expr.this.name works
There was a problem hiding this comment.
It's a tuple of properties.
There was a problem hiding this comment.
so we expect this to be EQ with the left operand being a string literal or an identifier
tobymao
approved these changes
May 13, 2024
izeigerman
force-pushed
the
chore-cosmetic-changes-to-resolve-session-properties
branch
from
56de418
to
6e996fd
Compare
izeigerman
deleted the
chore-cosmetic-changes-to-resolve-session-properties
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.