Fix: Ignore non-restateable models and print out a warning instead of failing the plan #2605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… failing the plan
tobymao
approved these changes
May 14, 2024
eakmanrq
reviewed
May 14, 2024
eakmanrq
reviewed
May 14, 2024
eakmanrq
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously SQLMesh would fail the plan if the restatement list contained a model which couldn't be restated.
When this behavior is combined with selectors, it results in a subpar experience, as the selector expression may encompass a large set of models, only a small portion of which cannot be restated.
This update changes the behavior so that an error is printed out for models that are part of the restatement list but cannot be restated instead failing the plan. It also completely ignores symbolic and seed models, as restating those is a no-op