Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix tests on windows #358

Merged
merged 4 commits into from Feb 26, 2023
Merged

Conversation

timmyichen
Copy link
Contributor

@timmyichen timmyichen commented Feb 25, 2023

Description

Fixes an issue around running tests on windows.

Tested by running npm run test on both mac and windows using this branch and ensuring that the test started as expected (did not wait for test completion)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • This change requires an update to testing

Issue

  • Is this related to a specific issue? If so, please specify:

Checklist:

  • This PR is up to date with the development branch, and merge conflicts have been resolved
  • I have executed npm run test and all tests have passed successfully or I have included details within my PR on the failure.

^ i have executed npm run test and verified it starts without throwing an error

  • Some windows users may not be able to execute this command. Please proceed with the PR if that is the case.
  • I have executed npm run lint and resolved any outstanding errors. Most issues can be solved by executing npm run format
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings

@Caleb-Cohen
Copy link
Member

This PR will pass now. A previous test failed but was reported as a success causing the PR to be improperly approved.

Screenshot 2023-02-25 at 6 26 18 PM

@Caleb-Cohen
Copy link
Member

@timmyichen unlike the first error I am unable to reproduce this one in my local.
Screenshot 2023-02-25 at 6 37 56 PM

Ensures date is in the middle/start of the month so all events are visible
@Caleb-Cohen Caleb-Cohen temporarily deployed to DEV February 26, 2023 17:43 — with GitHub Actions Inactive
@Caleb-Cohen Caleb-Cohen merged commit b7ba40a into Together-100Devs:main Feb 26, 2023
@timmyichen timmyichen deleted the tc-windows-tests branch February 26, 2023 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants