Fix #2160: Toplevel icon overriding on init #2162
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #2160.
There was a small bug and a bigger bug attempting to fix the previous bug.
self._iconbitmap_method_calledwas being initializedTruewhich meant the default CTK icon was never set by_windows_set_titlebar_icon(). To fix this there was a delayed action to force the default CTK icon after 200ms, but this one didn't call_windows_set_titlebar_icon()and didn't check if the icon had already been set either.Also,
wm_iconbitmap()was present buticonbitmap()was not and has now been added.