Update xmlDom dependency to fix security issues #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pang0018
commented
Jul 5, 2023
| @@ -229,7 +229,282 @@ function parsePlistXML (node) { | |||
| } | |||
|
|
|||
| }).call(this)}).call(this,require("buffer").Buffer) | |||
| },{"./xmldom/dom-parser":2,"buffer":7}],2:[function(require,module,exports){ | |||
| },{"@xmldom/xmldom":6,"buffer":9}],2:[function(require,module,exports){ | |||
There was a problem hiding this comment.
Not sure why all this changed, I just ran 'make' and this updated. Can revert if necessary.
mreinstein
requested changes
Jul 5, 2023
package.json
Outdated
| @@ -1,7 +1,7 @@ | |||
| { | |||
| "name": "plist", | |||
| "description": "Apple's property list parser/builder for Node.js and browsers", | |||
| "version": "3.0.6", | |||
| "version": "3.0.7", | |||
There was a problem hiding this comment.
don't bump the version number in this PR please, that'll be done separately.
There was a problem hiding this comment.
Reverted. Ready for another look!
|
Thanks for the PR! |
mreinstein
approved these changes
Jul 6, 2023
|
@mreinstein ty for merging this change so quickly. When will a new release with this change come out? |
|
Done. Published as 3.1.0. Thanks again for the PR! ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the xmlDom library dependency to not be embedded and to use the @xmldom/xmldom library. This resolves security issues with plist library
#136