Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(typings): allow port to be a string #72

Merged
merged 1 commit into from Oct 4, 2019
Merged

fix(typings): allow port to be a string #72

merged 1 commit into from Oct 4, 2019

Commits on Jul 14, 2019

  1. fix(typings): allow port to be a string 

    Fixing a regression spotted in pnpm: pnpm/pnpm#1905

The port in the Node.js URL object is a string, so it is more convenient to use string for the port.
https://nodejs.org/api/url.html#url_url_port
    @zkochan
    zkochan committed Jul 14, 2019
    Configuration menu
    Copy the full SHA
    8184268 View commit details
    Browse the repository at this point in the history