Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade React to 18.2.0 #262

Closed
wants to merge 3 commits into from
Closed

upgrade React to 18.2.0 #262

wants to merge 3 commits into from

Conversation

ryomahan
Copy link
Contributor

@ryomahan ryomahan commented Dec 4, 2022

upgrade React to 18.2.0

  • I hereby declare this contribution to be licenced under the MIT license

@ryomahan
Copy link
Contributor Author

ryomahan commented Dec 4, 2022

Problem List:

current react-router-dom version can't use in React.StrictMode

related articles:
React 18: react-router@v5 is breaking in the Strict Mode (strict effects)
[v5] Not compatible with React 18 StrictMode
Fix: make v5 Router compatible with v18 StrictMode

solution:
upgrade react-router-dom up to 5.3.3

state:

  • solution
  • test
  • commit

@ryomahan
Copy link
Contributor Author

ryomahan commented Dec 4, 2022

@mui/styles is not compatible with React.StrictMode or React 18

related articles:
@mui/styles docs
No result using makeStyles Material UI in react 18
makeStyles with a function css rule entry doesn't work on react 18 using react-dom/client createRoot

solution:
use tss-react to replace

change like this:

// before
import makeStyles from '@mui/styles/makeStyles';

const useStyles = makeStyles((theme) => ({
    ...
}));

const classes = useStyles(); 

// after
import { makeStyles } from "tss-react/mui";

const useStyles = makeStyles()((theme) => ({
    ...
}));

const { classes } = useStyles();

state:

  • solution
  • test
  • commit

@ryomahan
Copy link
Contributor Author

ryomahan commented Dec 4, 2022

redux is not re-rendering component with React 18

related articles:
redux is not re-rendering component with React 18

solution:
upgrade react-redux up to 7.2.8

state:

  • solution
  • test
  • commit

@ryomahan
Copy link
Contributor Author

ryomahan commented Dec 4, 2022

current react-flow-render version cannot support React 18's StrictMode

related articles:
Work not properly under React 18 with StrictMode

solution:
upgrade react-flow-render up to 10

state:

  • solution
  • test
  • commit

@ryomahan ryomahan closed this Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant