-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix minimal versions #174
base: main
Are you sure you want to change the base?
Fix minimal versions #174
Conversation
Would you mind contributing a |
I wound't mind, but as is it would not pass due to problems in transitive dependencies, in particular the minimal version for The CI workflow should be something like this: minimal-versions:
name: Check minimal versions
strategy:
matrix:
include:
- os: ubuntu-latest
features: vulkan,visualizer
- os: windows-latest
features: vulkan,visualizer,d3d12,public-winapi
runs-on: ${{ matrix.os }}
steps:
- uses: actions/checkout@v3
- uses: actions-rs/toolchain@v1
with:
profile: minimal
toolchain: nightly
override: true
- uses: taiki-e/install-action@cargo-hack
- uses: taiki-e/install-action@cargo-minimal-versions
- run: cargo minimal-versions build --workspace --features ${{ matrix.features }} --no-default-features |
I'm researching the potential of using
Perhaps we can bump the requirement here to at least |
The backtrace crate is now entirely gone: #186 🎉 |
13cdb70
to
3148272
Compare
3148272
to
dea4fa4
Compare
dea4fa4
to
68f0ee1
Compare
68f0ee1
to
cb68e68
Compare
I was trying to compile
bevy
usingcargo minimal-versions
and noticed thatgpu-allocator
depended onbacktrace 0.3
andlog 0.4
, but actually used features frombacktrace 0.3.3
(Backtrace::new_unresolved
andBacktrace::resolve
) andlog 0.4.9
(didn't import thelog!
macro when callinglog::warn!
; could be fixed by importing it too if you prefer it, but looks unnecessary), which made the build fail.