Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cargo: Bump windows crate range to 0.53-0.56 #213

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

MarijnS95
Copy link
Member

@MarijnS95 MarijnS95 commented Mar 11, 2024

Allow windows 0.53 all the way up to and including 0.56 to be used, and remove some unused features from the core crate.

@MarijnS95 MarijnS95 changed the title cargo: Allow up to and including Windows 0.54 crate cargo: Allow up to and including Windows 0.56 crate Apr 12, 2024
@Systemcluster
Copy link

Systemcluster commented Apr 12, 2024

The ComInterface trait seems to be just Interface since 0.53: microsoft/windows-rs#2875 (comment)

I'm not sure why it's not mentioned in the release notes. Interface seems to work down to at least 0.51 though, so I think you can just replace it without bumping the lower version bound. (edit: It's just in the example anyways so it shouldn't matter much.)

@MarijnS95 MarijnS95 force-pushed the windows-0.54-0.55 branch 2 times, most recently from aa99351 to f414708 Compare April 12, 2024 21:06
@MarijnS95 MarijnS95 changed the title cargo: Allow up to and including Windows 0.56 crate cargo: Bump windows crate range to 0.53-0.56 Apr 12, 2024
@cwfitzgerald
Copy link

cwfitzgerald commented May 20, 2024

This would be great to get in, I've started depending on it locally. Is there anything an outsider could do to help move this along?

MarijnS95 and others added 3 commits May 20, 2024 23:36
Because of the refactoring of `CanInto` (to now only support `unsafe`
`IntoParam` boilerplate for `Abi` purposes) in favour of regular `From`
implementations for type-safe upcasting, the new releases are no longer
backwards-compatible with `windows 0.51-0.52`.
Most namespaces are parents which are enabled automatically when
enabling their childeren (and the root `Win32` namespace depends on
`Win32_Foundation` since newer `windows` releases).  Except `Direct3D`,
which is not required for `gpu-allocator` but only used in the examples.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants