- Added 100% coverage for utils/languages.js. #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Minor bug fixes: - Handling if no language/null is supplied to addLanguage(). - Add check if invalid language is supplied to addLanguage().
… 3.* >If both package.json and yarn.lock are present in the current directory, we run the following command instead of npm install.
- [ ] Checked, this fixes the issue where test failed for *Node.js: 5.11*
…endar into Test-languages-js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PASS test/languages.test.js
PASS test/language-validator.test.js
Test Suites: 2 passed, 2 total
Tests: 10 passed, 10 total
Snapshots: 0 total
Time: 0.872s, estimated 1s
Ran all test suites.
-----------------------|----------|----------|----------|----------|-------------------|
File | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s |
-----------------------|----------|----------|----------|----------|-------------------|
All files | 100 | 100 | 100 | 100 | |
language-validator.js | 100 | 100 | 100 | 100 | |
languages.js | 100 | 100 | 100 | 100 | |
-----------------------|----------|----------|----------|----------|-------------------|