Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: Implement Dark Mode #95

Open
wants to merge 42 commits into
base: main
Choose a base branch
from
Open

style: Implement Dark Mode #95

wants to merge 42 commits into from

Conversation

Readpato
Copy link
Collaborator

Description

Summary

Changes

What kind of change does this PR introduce? (check at least one by adding an "x" between the brackets)

  • Build-related changes
  • Bugfix
  • Code style update
  • Feature
  • Refactor
  • Style:
    • Implement dark mode
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

Screenshots and videos

  • If applicable, add screenshots or a video to help explain your problem.
leches-dark-mode.mov

The PR fulfils these requirements:

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Dark mode is a good implementation to improve the UX for everyone that utilizes the package.

Other information:

Let me know any changes that need to be done if needed!

@Readpato Readpato self-assigned this Dec 17, 2023
Copy link

netlify bot commented Dec 17, 2023

Deploy Preview for tresleches ready!

Name Link
🔨 Latest commit a6198c5
🔍 Latest deploy log https://app.netlify.com/sites/tresleches/deploys/65801f6fce7048000877fe7c
😎 Deploy Preview https://deploy-preview-95--tresleches.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Readpato Readpato mentioned this pull request Dec 17, 2023
11 tasks
@alvarosabu
Copy link
Member

Hey @Readpato thanks for taking the time to bring everything from the fork to the repo and for the granular and detailed git commit history, 👏🏻

Small thing, (I missed it when asking the first time) when creating the branch add the number of the issue like feat/75-dark-mode

I'm gonna check the PR today, let you know soon

@alvarosabu
Copy link
Member

Screenshot 2023-12-18 at 11 06 38

Folders look different now, they had a subtle gray background and no border before.

@alvarosabu
Copy link
Member

@Readpato I just committed a small change regarding the styles of the icon for toggling the dark mode.

Before it had the same visual hierarchy as the cake icon (which symbolizes the mini branding of the component and will serve as an expand/collapse button in the near future) so since the functionality is also different I changed for a more subtle icon (also the right part is gonna serve as a toolbar of actions, where we will add a search icon soon)

Screenshot 2023-12-18 at 11 29 25 Screenshot 2023-12-18 at 11 29 38

Let me know what do you think

Copy link
Member

@alvarosabu alvarosabu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazin job @Readpato, looks amazing

@@ -20,18 +20,18 @@ const toggle = () => {
</script>

<template>
<div class="tl-mb-4">
<div class="tl-mb-4 tl-w-full tl-border-x-none tl-border-solid tl-border-1 tl-border-primary">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2023-12-18 at 11 06 38

Folders look different now, they had a subtle gray background and no border before.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there! I tried to emulate the tweak pane folder component, which it clearly denoted the separation between one folder and another. I don't mind turning it back or adapting the old styles (which I removed without asking, my bad) to the new component =] Let me know!

@Readpato
Copy link
Collaborator Author

Hey @alvarosabu! Thank you for your review. Means a lot <3
I'm totally on board with utilizing an icon instead of an emoji for toggling the dark mode.
Also, I was wondering to properly commit to a project, sometimes I notice that different files are being modified automatically like stats.html, auto-imports.d.ts, etc. Should I commit those as well whenever I work on the project?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dark mode
2 participants