fix: push only tags when skip-commit and git-push #218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's an edge case where if skip-commit is true as well as git-push, and you follow the instructions for skipping git pull and a commit gets pushed to the branch while this is running, that it will fail the job. This is because when pushing the results, it would also push the branch. Pushing the branch isn't necessary though. This doesn't fix the edge case though if skip-commit is false but you'd likely want that to fail then in that case.
|
Thanks! |
|
I'll fix the tests when I get a chance |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's an edge case where if skip-commit is true as well as git-push, and you follow the instructions for skipping git pull and a commit gets pushed to the branch while this is running, that it will fail the job. This is because when pushing the results, it would also push the branch. Pushing the branch isn't necessary though. This doesn't fix the edge case though if skip-commit is false but you'd likely want that to fail then in that case.