Skip to content

Commit

Permalink
feat: Upgrade nx (#270)
Browse files Browse the repository at this point in the history
BREAKING CHANGE: Updated Nx to 19

Notes:
* `nx` upgrade from 18.3.3 to 19.0.3;
* no `nx` migrations were needed;
* updated `yarn.lock`;
* changed `test` script in `package.json` to run all tests;
* all tests are passing after upgrade.

Reason of opening:
I keep getting unmet dependencies when trying to upgrade to newest `nx`:
```
 WARN  Issues with peer dependencies found
.
└─┬ @nx-extend/shadcn-ui 1.1.0
  └─┬ @nx/devkit 18.0.2
    ├── ✕ unmet peer nx@">= 16 <= 18": found 19.0.3
    └─┬ @nrwl/devkit 18.0.2
      └─┬ @nx/devkit 18.0.2
        └── ✕ unmet peer nx@">= 16 <= 18": found 19.0.3

```
  • Loading branch information
gurisko committed May 15, 2024
1 parent ecdb923 commit 8ce59d8
Show file tree
Hide file tree
Showing 2 changed files with 209 additions and 210 deletions.
22 changes: 11 additions & 11 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -28,13 +28,13 @@
"nx": "nx",
"nx:update": "nx migrate latest",
"start": "nx serve",
"test": "nx test",
"test": "nx run-many --all -t test",
"workspace-generator": "nx workspace-generator"
},
"dependencies": {
"@actions/core": "^1.10.1",
"@nx/devkit": "18.3.3",
"@nx/workspace": "18.3.3",
"@nx/devkit": "19.0.3",
"@nx/workspace": "19.0.3",
"@types/tar": "^6.1.13",
"axios": "^1.6.8",
"crypto-js": "^4.2.0",
Expand All @@ -49,13 +49,13 @@
"@google-cloud/storage": "^7.10.1",
"@jamesives/github-pages-deploy-action": "^4.6.0",
"@jscutlery/semver": "^5.2.2",
"@nx/eslint-plugin": "18.3.3",
"@nx/jest": "18.3.3",
"@nx/js": "18.3.3",
"@nx/node": "18.3.3",
"@nx/plugin": "18.3.3",
"@nx/react": "18.3.3",
"@nx/webpack": "18.3.3",
"@nx/eslint-plugin": "19.0.3",
"@nx/jest": "19.0.3",
"@nx/js": "19.0.3",
"@nx/node": "19.0.3",
"@nx/plugin": "19.0.3",
"@nx/react": "19.0.3",
"@nx/webpack": "19.0.3",
"@swc-node/register": "1.8.0",
"@swc/core": "1.5.0",
"@types/jest": "29.5.12",
Expand All @@ -73,7 +73,7 @@
"husky": "^9.0.11",
"jest": "29.7.0",
"jest-environment-jsdom": "29.7.0",
"nx": "18.3.3",
"nx": "19.0.3",
"prettier": "3.2.5",
"ts-jest": "29.1.2",
"ts-node": "10.9.2",
Expand Down

0 comments on commit 8ce59d8

Please sign in to comment.