Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: reuse mod.ssrError #1

Merged
merged 2 commits into from Mar 7, 2022
Merged

Conversation

Rich-Harris
Copy link

Description

Thank you for the PR to fix vitejs#7030. This addresses my comments in vitejs#7177 (comment) — by storing the error thrown during module instantiation, we can a) save the effort of reinstantiating it, and b) hew closer to the behaviour of browsers and node.

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@TrickyPi
Copy link
Owner

TrickyPi commented Mar 7, 2022

Thanks for your professional fix

@TrickyPi TrickyPi merged commit 7d90e1b into TrickyPi:fix-7030 Mar 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants