Skip to content

Commit

Permalink
doc: remove squash guideline from onboarding doc
Browse files Browse the repository at this point in the history
Although I agree with the guideline people should generally not squash
commits in a pull request until the end (in other words, until it's time
to land the PR), it is clear from comments and actions in the issue
tracker that many do not share that view. This is fine by me, but I do
think that we should our documentation should reflect our practices
rather than being an aspirational statement.

If we *do* wish to preserve this recommendation, it probably belongs in
another document anyway as this is not a recommendation for
Collaborators only but for anyone opening a pull request.

PR-URL: nodejs#20413
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
  • Loading branch information
Trott committed May 3, 2018
1 parent 7588cea commit ac6d1f2
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion doc/onboarding-extras.md
Expand Up @@ -97,4 +97,3 @@ to update from nodejs/node:
## Best practices

* When making PRs, spend time writing a thorough description.
* Usually only squash at the end of your work.

0 comments on commit ac6d1f2

Please sign in to comment.