Skip to content

Commit

Permalink
Added support for Node 20
Browse files Browse the repository at this point in the history
ref https://linear.app/tryghost/issue/ENG-765/add-support-for-node-20

- this adds support for Node 20 to Ghost and CI, as Node 20 is an LTS
  version
  • Loading branch information
daniellockyer committed Mar 19, 2024
1 parent 134c33c commit 850cda1
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 5 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/ci.yml
Expand Up @@ -417,7 +417,7 @@ jobs:
if: needs.job_get_metadata.outputs.changed_any_code == 'true'
strategy:
matrix:
node: [ '18.12.1' ]
node: [ '18.12.1', '20.11.1' ]
name: Unit tests (Node ${{ matrix.node }})
steps:
- uses: actions/checkout@v4
Expand Down Expand Up @@ -455,7 +455,7 @@ jobs:
if: needs.job_get_metadata.outputs.changed_core == 'true'
strategy:
matrix:
node: [ '18.12.1' ]
node: [ '18.12.1', '20.11.1' ]
env:
- DB: mysql8
NODE_ENV: testing-mysql
Expand Down
4 changes: 2 additions & 2 deletions ghost/admin/package.json
Expand Up @@ -26,7 +26,7 @@
"lint": "yarn lint:js && yarn lint:hbs"
},
"engines": {
"node": "^18.12.1"
"node": "^18.12.1 || ^20.11.1"
},
"devDependencies": {
"@babel/eslint-parser": "7.23.3",
Expand Down Expand Up @@ -201,4 +201,4 @@
}
}
}
}
}
2 changes: 1 addition & 1 deletion ghost/core/package.json
Expand Up @@ -53,7 +53,7 @@
"prepack": "node monobundle.js"
},
"engines": {
"node": "^18.12.1",
"node": "^18.12.1 || ^20.11.1",
"cli": "^1.25.0"
},
"dependencies": {
Expand Down

0 comments on commit 850cda1

Please sign in to comment.