Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added e2e test for member.added webhook #15554

Merged

Conversation

illiteratewriter
Copy link
Contributor

refs #15537

@daniellockyer daniellockyer requested a review from naz October 7, 2022 05:42
@codecov
Copy link

codecov bot commented Oct 7, 2022

Codecov Report

Base: 52.46% // Head: 52.46% // No change to project coverage 👍

Coverage data is based on head (131938c) compared to base (06f6fc1).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #15554   +/-   ##
=======================================
  Coverage   52.46%   52.46%           
=======================================
  Files        1433     1433           
  Lines       92897    92897           
  Branches    10358    10358           
=======================================
  Hits        48739    48739           
+ Misses      42940    42937    -3     
- Partials     1218     1221    +3     
Impacted Files Coverage Δ
ghost/admin/app/utils/publish-options.js 75.72% <0.00%> (-1.16%) ⬇️
ghost/admin/app/controllers/offer.js 42.10% <0.00%> (+0.52%) ⬆️
ghost/admin/app/components/gh-site-iframe.js 45.45% <0.00%> (+2.27%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@naz naz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome change @illiteratewriter 👏 Good to be merged

@daniellockyer daniellockyer changed the title added e2e tests for members.added Added e2e test for member.added webhook Oct 7, 2022
@daniellockyer daniellockyer merged commit a0ec94f into TryGhost:main Oct 7, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Oct 7, 2022

Thank you for your PR 🙏 It has now been merged 🎉 and will be in the next release, which is usually on a Friday. Hope to see you again soon 👋

@daniellockyer daniellockyer mentioned this pull request Oct 7, 2022
29 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants