Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

馃悰 Fixed HTTP 500 error when given incorrect Range header #19834

Merged
merged 1 commit into from Mar 11, 2024
Merged

馃悰 Fixed HTTP 500 error when given incorrect Range header #19834

merged 1 commit into from Mar 11, 2024

Commits on Mar 11, 2024

  1. 馃悰 Fixed HTTP 500 error when given incorrect Range header 

    ref ENG-729
ref https://linear.app/tryghost/issue/ENG-729/incorrect-range-header-leads-to-http-500-errors

- we didn't have handling here for the `RangeNotSatisfiableError` that
  can come from express/serve-static/send
- as a result, passing an invalid range would cause a 500 error
- this prevents that and adds a breaking test
    @daniellockyer
    daniellockyer committed Mar 11, 2024
    Copy the full SHA
    c343820 View commit details
    Browse the repository at this point in the history