Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

馃悰 Fixed missing source + resized images producing rendered 404 #19869

Merged
merged 2 commits into from Mar 18, 2024
Merged

馃悰 Fixed missing source + resized images producing rendered 404 #19869

merged 2 commits into from Mar 18, 2024

Commits on Mar 14, 2024

  1. 馃悰 Fixed missing source + resized images producing rendered 404 

    fixes https://linear.app/tryghost/issue/ENG-746/http-500-responses-when-handle-image-sizes-middleware-hits-missing

- in the event a request comes in for a resized image, but the source
  image does not exist, we return a rendered 404 page
- we do this because we pass the NotFoundError to `next`, which skips
  over the static asset code where we return a plaintext 404
- also included a breaking test that ensure we go to the next middleware
  without an error
    @daniellockyer
    daniellockyer committed Mar 14, 2024
    Copy the full SHA
    68ab120 View commit details
    Browse the repository at this point in the history

Commits on Mar 15, 2024

  1. added e2e test

    @daniellockyer
    daniellockyer committed Mar 15, 2024
    Copy the full SHA
    622860f View commit details
    Browse the repository at this point in the history