Cached api controller pipelines #19880
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ref ENG-761 ref https://linear.app/tryghost/issue/ENG-761 Creating these pipelines is expensive, and we don't want to do it repeatedly for the same controller. Adding caching should reduce the amount of time spent setting up pipelines for each usage of the `get` helper.
| @@ -267,6 +273,10 @@ const pipeline = (apiController, apiUtils, apiType) => { | |||
| Object.assign(obj[method], apiImpl); | |||
| return obj; | |||
| }, {}); | |||
|
|
|||
| controllerMap.set(apiController, result); | |||
There was a problem hiding this comment.
Would it be worth using docName as the key?
There was a problem hiding this comment.
docName isn't unique - so no! 😝
There was a problem hiding this comment.
One of the things docName is used for is to determine which permissions to use - so the pages endpoint has a docName of 'posts' - as does the postsPublic endpoint
allouis
deleted the
egg-eng-761-api-pipeline-is-cpu-intensive-and-created-on-the-fly-2
branch
royalfig
pushed a commit
that referenced
this pull request
Mar 25, 2024
ref ENG-761 ref https://linear.app/tryghost/issue/ENG-761 Creating these pipelines is expensive, and we don't want to do it repeatedly for the same controller. Adding caching should reduce the amount of time spent setting up pipelines for each usage of the `get` helper.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref ENG-761
ref https://linear.app/tryghost/issue/ENG-761
Creating these pipelines is expensive, and we don't want to do it repeatedly for the same controller. Adding caching should reduce the amount of time spent setting up pipelines for each usage of the
gethelper.