Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed used of fs-extra from @tryghost/logging #140

Merged
merged 2 commits into from Mar 11, 2024
Merged

Removed used of fs-extra from @tryghost/logging #140

merged 2 commits into from Mar 11, 2024

Commits on Mar 11, 2024

  1. Removed used of fs-extra from @tryghost/logging 

    ref SLO-14
ref https://linear.app/tryghost/issue/SLO-14/improved-speed-of-migratejs-script

- fs-extra can be a really heavy library when you're trying to stay lean
- we don't need it here because `fs` natively comes with a sync `exists`
  method
- this replaces `fs-extra` with `fs`
    @daniellockyer
    daniellockyer committed Mar 11, 2024
    Copy the full SHA
    f996e89 View commit details
    Browse the repository at this point in the history

  2. Added RangeNotSatisfiableError error 

    ref ENG-729
ref https://linear.app/tryghost/issue/ENG-729/incorrect-range-header-leads-to-http-500-errors

- this will be used when the content Ghost is trying to serve cannot be
  satisfied for the provided range
    @daniellockyer
    daniellockyer committed Mar 11, 2024
    Copy the full SHA
    e6b07ac View commit details
    Browse the repository at this point in the history