refactor: use bindings to load .node file #1263
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR alters
.node
file loading to usebindings
. I'd like to make this change because it enables Webpack to understand how to handle this module, a need which would apply to, for example, Electron apps which both need to use native node modules and use Webpack.This should not disrupt any existing functionality, and
bindings
itself only has one dependency, which makes this change have minimal impact as far as added dependencies are concerned.Thank you!