Support calling close() on cached.Database() #1407
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhansen
added a commit
to ether/ueberDB
that referenced
this pull request
Dec 7, 2020
The `sqlite3.cached.Database()` function returns a Database object that cannot be safely closed. See: TryGhost/node-sqlite3#1407
rhansen
force-pushed
the
cached-close
branch
2 times, most recently
from
aaf95e2
to
bf0d988
Compare
rhansen
force-pushed
the
cached-close
branch
2 times, most recently
from
81d4683
to
92d7288
Compare
Introduce a refcount for cached Database entries so that calling close() on the Database returned from cached.Database() does not invalidate existing or future uses of the same cached Database. This is a backwards-incompatible change because it changes the number of times close() must be called before the underlying Database is closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce a refcount for cached
Databaseentries so that callingclose()on theDatabasereturned fromcached.Database()does not invalidate existing or future uses of the same cachedDatabase.This is a backwards-incompatible change because it changes the number of times
close()must be called before the underlyingDatabaseis closed.